This repository was archived by the owner on May 9, 2023. It is now read-only.
Include FQDN in canonical URLs, show full page URL.#478
Merged
Conversation
Jkrzy
approved these changes
Apr 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #430.
The canonical URL should be the clean path to the current page, including the hostname. This PR implements that fix.
Additionally, since these are now URLs which point to production, HTMLProofer tries to check to see if these URLs are broken, which causes all new pages to fail builds. Fixed this issue by treating any URL to
https://faq.coronavirus.govas local in the HTMLProofer configuration.